public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/atomic: Allocate atomic_state at the beginning of atomic_ioctl
Date: Wed, 11 Feb 2026 16:31:47 +1000	[thread overview]
Message-ID: <review-patch3-20260210-atomic-v9-3-525c88fd2402@intel.com> (raw)
In-Reply-To: <20260210-atomic-v9-3-525c88fd2402@intel.com>

Patch Review

**Issues:**

```c
+	state = drm_atomic_state_alloc(dev);
+	if (!state)
+		return -ENOMEM;
+
+	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
+	state->acquire_ctx = &ctx;
+	state->allow_modeset = !!(arg->flags & DRM_MODE_ATOMIC_ALLOW_MODESET);
+
 	/* disallow for userspace that has not enabled atomic cap (even
 	 * though this may be a bit overkill, since legacy userspace
 	 * wouldn't know how to call this ioctl)
 	 */
 	if (!file_priv->atomic) {
```
- **Performance Regression**: Now allocating state for requests that will immediately fail validation. This wastes memory and CPU cycles for invalid requests.

```c
-	if (arg->reserved) {
-		drm_dbg_atomic(dev, "commit failed: reserved field set\n");
-		ret = -EINVAL;
-		goto out;
-	}
```
- **ABI Change**: Removing the `reserved` field check fundamentally changes the userspace contract. Old userspace that accidentally sets this field will now have different behavior.
- **Backward Compatibility**: This breaks the principle that reserved fields must be zero.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-11  6:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  9:03 [PATCH v9 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-02-10  9:03 ` [PATCH v9 1/7] drm: Define user readable error codes for atomic ioctl Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot
2026-02-10  9:03 ` [PATCH v9 2/7] drm/atomic: Add error_code element in atomic_state Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot
2026-02-10  9:03 ` [PATCH v9 3/7] drm/atomic: Allocate atomic_state at the beginning of atomic_ioctl Arun R Murthy
2026-02-11  6:31   ` Claude Code Review Bot [this message]
2026-02-10  9:03 ` [PATCH v9 4/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot
2026-02-10  9:03 ` [PATCH v9 5/7] drm/atomic: Return user readable error in atomic_ioctl Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot
2026-02-10  9:04 ` [PATCH v9 6/7] drm/i915/display: Error codes for async flip failures Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot
2026-02-10  9:04 ` [PATCH v9 7/7] drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot
2026-02-11  6:31 ` Claude review: User readable error codes on atomic_ioctl failure Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260210-atomic-v9-3-525c88fd2402@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox