From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: clk: bcm: rpi: Mark PIXEL_CLK and HEVC_CLK as CLK_IGNORE_UNUSED Date: Sat, 14 Feb 2026 07:21:52 +1000 Message-ID: In-Reply-To: <20260213-v3d-power-management-v5-3-7a8b381eb379@igalia.com> References: <20260213-v3d-power-management-v5-0-7a8b381eb379@igalia.com> <20260213-v3d-power-management-v5-3-7a8b381eb379@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review > - .flags =3D CLK_IS_CRITICAL, > + .flags =3D CLK_IGNORE_UNUSED, Changed for both `PIXEL_CLK` and `HEVC_CLK`. The commit message explains that= these clocks are consumed by specific drivers (vc4, HEVC decoder), so markin= g them `CLK_IGNORE_UNUSED` instead of `CLK_IS_CRITICAL` allows the clock fram= ework's late cleanup to skip them while still permitting their respective dri= vers to control them. This is the correct flag for clocks that have consumers= but might appear unused to the clock framework at certain points during boot. No issues found. --- Generated by Claude Code Patch Reviewer