From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: panel-jadard-jd9365da-h3: support for taiguan-xti05101-01a MIPI-DSI panel Date: Fri, 13 Feb 2026 18:03:34 +1000 Message-ID: In-Reply-To: <20260213071946.1436852-4-yelangyan@huaqin.corp-partner.google.com> References: <20260213071946.1436852-1-yelangyan@huaqin.corp-partner.google.com> <20260213071946.1436852-4-yelangyan@huaqin.corp-partner.google.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The init command function and panel descriptor follow the existing patterns i= n this driver correctly. > +static const struct jadard_panel_desc taiguan_xti05101_01a_desc =3D { > + .mode =3D { > + .clock =3D (800 + 24 + 24 + 24) * (1280 + 30 + 4 + 8) * 60 / 1000, The mode timings are identical to the `melfas_lmfbx101117480_desc` panel (sam= e resolution, same porch values, same physical size). The clock expression ev= aluates to 69158 kHz. This is consistent. The descriptor does not set `.mode_flags`, which means the probe function wil= l apply the default: `MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_= DSI_MODE_NO_EOT_PACKET`. This matches the pattern used by the `melfas` panel = and other panels in this driver that don't override mode_flags. > + return dsi_ctx.accum_err; > +}; The trailing semicolon after the function definition closing brace is technic= ally unnecessary, but this is a pre-existing pattern used by every init funct= ion in this file, so it's consistent. No issues found in this patch. The init command sequence, panel descriptor, a= nd OF match table entry all follow the established conventions of the driver. --- Generated by Claude Code Patch Reviewer