From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vgaarb: mark vga_get family as __must_check Date: Wed, 18 Feb 2026 06:47:57 +1000 Message-ID: In-Reply-To: <20260217170419.236739-4-Simon.Richter@hogyros.de> References: <20260217170419.236739-1-Simon.Richter@hogyros.de> <20260217170419.236739-4-Simon.Richter@hogyros.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch adds `__must_check` to `vga_get`, `vga_get_interruptible`, and `vga_get_uninterruptible`. The change is reasonable in principle, but it will cause new compiler warnings for existing callers that don't check the return value. Specifically, `drivers/gpu/drm/i915/display/intel_vga.c` has two call sites: ```c vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); ``` at lines 68 and 93, neither of which checks the return value. Adding `__must_check` without fixing these callers will introduce build warnings (or errors with `-Werror`). These callers should be fixed in this series, or at minimum the commit message should acknowledge the known warnings. --- Generated by Claude Code Patch Reviewer