public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/atomic: Call complete_signaling only if prepare_signaling is done
Date: Tue, 24 Feb 2026 10:26:59 +1000	[thread overview]
Message-ID: <review-patch3-20260223-atomic-v10-3-f59c8def2e70@intel.com> (raw)
In-Reply-To: <20260223-atomic-v10-3-f59c8def2e70@intel.com>

Patch Review

> -	unsigned int i, j, num_fences;
> +	unsigned int i, j, num_fences = 0;

> -	complete_signaling(dev, state, fence_state, num_fences, !ret);
> +	if (num_fences)
> +		complete_signaling(dev, state, fence_state, num_fences, !ret);

This change is correct in isolation. Before this series, `complete_signaling` was always called after `prepare_signaling`. With the state allocation moved earlier (patch 4), early `goto out` paths can reach the cleanup before `prepare_signaling` runs. Initializing `num_fences = 0` and guarding the call is the right approach.

I verified that `complete_signaling` cleans up both fence state and crtc events. When `prepare_signaling` was never called, there are no events or fences to clean up, so skipping the call when `num_fences == 0` is safe. The events and fences are only created together in `prepare_signaling`, and `num_fences` is incremented for each one.

No issues found in this patch.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-24  0:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  9:15 [PATCH v10 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-02-23  9:15 ` [PATCH v10 1/7] drm: Define user readable error codes for atomic ioctl Arun R Murthy
2026-02-24  0:26   ` Claude review: " Claude Code Review Bot
2026-02-23  9:16 ` [PATCH v10 2/7] drm/atomic: Add error_code element in atomic_state Arun R Murthy
2026-02-24  0:26   ` Claude review: " Claude Code Review Bot
2026-02-23  9:16 ` [PATCH v10 3/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-02-24  0:26   ` Claude Code Review Bot [this message]
2026-02-23  9:16 ` [PATCH v10 4/7] drm/atomic: Allocate atomic_state at the beginning of atomic_ioctl Arun R Murthy
2026-02-24  0:27   ` Claude review: " Claude Code Review Bot
2026-02-23  9:16 ` [PATCH v10 5/7] drm/atomic: Return user readable error in atomic_ioctl Arun R Murthy
2026-02-24  0:27   ` Claude review: " Claude Code Review Bot
2026-02-23  9:16 ` [PATCH v10 6/7] drm/i915/display: Error codes for async flip failures Arun R Murthy
2026-02-24  0:27   ` Claude review: " Claude Code Review Bot
2026-02-23  9:16 ` [PATCH v10 7/7] drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING Arun R Murthy
2026-02-24  0:27   ` Claude review: " Claude Code Review Bot
2026-02-23 10:07 ` [PATCH v10 0/7] User readable error codes on atomic_ioctl failure Murthy, Arun R
2026-02-24  0:26 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-10  9:03 [PATCH v9 0/7] " Arun R Murthy
2026-02-10  9:03 ` [PATCH v9 4/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260223-atomic-v10-3-f59c8def2e70@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox