From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: pwm: th1520: remove impl Send/Sync for Th1520PwmDriverData Date: Tue, 24 Feb 2026 10:11:36 +1000 Message-ID: In-Reply-To: <20260223-clk-send-sync-v5-3-181bf2f35652@google.com> References: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> <20260223-clk-send-sync-v5-3-181bf2f35652@google.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > -// SAFETY: The `devres` framework requires the driver's private data to be `Send` and `Sync`. > -// We can guarantee this because the PWM core synchronizes all callbacks, preventing concurrent > -// access to the contained `iomem` and `clk` resources. > -unsafe impl Send for Th1520PwmDriverData {} > - > -// SAFETY: The same reasoning applies as for `Send`. The PWM core's synchronization > -// guarantees that it is safe for multiple threads to have shared access (`&self`) > -// to the driver data during callbacks. > -unsafe impl Sync for Th1520PwmDriverData {} Removal is correct. `Th1520PwmDriverData` contains `Devres>` (which is `Send`+`Sync` when `IoMem` is `Send`, which it should be) and `Clk` (now `Send`+`Sync` after patch 1). Auto-derivation will work. Note: the quoted-printable encoding in the mbox (`=20`, `=3D`, line continuations with `=`) is a transport artifact and does not affect the actual patch content. No issues found. --- Generated by Claude Code Patch Reviewer