public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: Switch private_obj initialization to atomic_create_state
Date: Fri, 27 Feb 2026 15:05:37 +1000	[thread overview]
Message-ID: <review-patch3-20260224-drm-private-obj-reset-v5-3-5a72f8ec9934@kernel.org> (raw)
In-Reply-To: <20260224-drm-private-obj-reset-v5-3-5a72f8ec9934@kernel.org>

Patch Review

**Commit message**: Clear and well-written.

**Code review**:

The new `tegra_display_hub_create_state()` is structurally identical to the omapdrm version and is correct:

```c
static struct drm_private_state *
tegra_display_hub_create_state(struct drm_private_obj *obj)
{
	struct tegra_display_hub_state *hub_state;

	hub_state = kzalloc_obj(*hub_state);
	if (!hub_state)
		return ERR_PTR(-ENOMEM);

	__drm_atomic_helper_private_obj_create_state(obj, &hub_state->base);

	return &hub_state->base;
}
```

**Same issue: Missing return value check:**

```c
	drm_atomic_private_obj_init(drm, &hub->base, NULL,
				    &tegra_display_hub_state_funcs);

	tegra->hub = hub;

	return 0;
```

Should check the return value and propagate errors.

**Note**: I realize this same return-value-not-checked pattern exists in many other already-converted callers (komeda, ingenic, dpu, mdp5, vc4, drm_bridge, drm_dp_mst, drm_dp_tunnel). This is a wider pre-existing issue, but patches 1-3 should not perpetuate it. At minimum the three patches being submitted should get it right.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-27  5:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 16:10 [PATCH v5 0/4] drm/atomic: Allocate drm_private_state through a callback Maxime Ripard
2026-02-24 16:10 ` [PATCH v5 1/4] drm/amdgpu: Switch private_obj initialization to atomic_create_state Maxime Ripard
2026-02-27  5:05   ` Claude review: " Claude Code Review Bot
2026-02-24 16:10 ` [PATCH v5 2/4] drm/omapdrm: " Maxime Ripard
2026-02-27  5:05   ` Claude review: " Claude Code Review Bot
2026-02-24 16:10 ` [PATCH v5 3/4] drm/tegra: " Maxime Ripard
2026-02-27  5:05   ` Claude Code Review Bot [this message]
2026-02-24 16:10 ` [PATCH v5 4/4] drm/atomic: Remove state argument to drm_atomic_private_obj_init Maxime Ripard
2026-02-27  5:05   ` Claude review: " Claude Code Review Bot
2026-02-27  5:05 ` Claude review: drm/atomic: Allocate drm_private_state through a callback Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260224-drm-private-obj-reset-v5-3-5a72f8ec9934@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox