From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: ti: k3-j784s4: Add GPU node
Date: Fri, 27 Feb 2026 14:48:58 +1000
Message-ID: <review-patch3-20260224-gpu_dts-v1-3-cc5ddffe140c@ti.com>
In-Reply-To: <20260224-gpu_dts-v1-3-cc5ddffe140c@ti.com>
References: <20260224-gpu_dts-v1-0-cc5ddffe140c@ti.com> <20260224-gpu_dts-v1-3-cc5ddffe140c@ti.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Author:** Antonios Christidis

Adds the BXS-464 GPU node for the J784S4 SoC.

```dts
gpu: gpu@4e20000000 {
    compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";
    reg = <0x4e 0x20000000 0x00 0x80000>;
    clocks = <&k3_clks 181 1>;
    clock-names = "core";
    assigned-clocks = <&k3_clks 181 1>;
    assigned-clock-rates = <800000000>;
    interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
    power-domains = <&k3_pds 181 TI_SCI_PD_EXCLUSIVE>,
        <&k3_pds 182 TI_SCI_PD_EXCLUSIVE>;
    power-domain-names = "a", "b";
    dma-coherent;
};
```

- Uses `"ti,j721s2-gpu"` as the SoC-specific compatible -- this reuses the existing J721S2 compatible rather than introducing a new J784S4-specific one. This makes sense if the J784S4 GPU block is identical to J721S2's, but the cover letter and commit message should explain this choice.
- **No new dt-binding needed** since `ti,j721s2-gpu` already exists in the binding, which is consistent.
- **Indentation inconsistency** in `power-domains`: uses a single tab indent for the continuation line, while patch 1 uses a double tab. This is minor but worth keeping consistent across the series:

  Patch 1:
  ```
  power-domains = <&k3_pds 125 TI_SCI_PD_EXCLUSIVE>,
  		<&k3_pds 126 TI_SCI_PD_EXCLUSIVE>;
  ```
  Patch 3:
  ```
  power-domains = <&k3_pds 181 TI_SCI_PD_EXCLUSIVE>,
  	<&k3_pds 182 TI_SCI_PD_EXCLUSIVE>;
  ```

- Same `status = "disabled"` question as patch 1.
- The commit message says "Add the Series BXS GPU node" -- "Series" should probably be lowercase or the whole identifier should be quoted/clarified (e.g., "BXS-464").

---

---
Generated by Claude Code Patch Reviewer