Claude review: accel/qda: Add RPMsg transport for Qualcomm DSP accelerator

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

Adds `qda_dev` structure, custom logging macros, and RPMsg client driver.

- **Custom logging macros** (lines 1413-1437 of mbox): Both Bjorn and Dmitry flagged these. The `qda_err`/`qda_info`/`qda_dbg` macros wrap `dev_err`/`pr_err` with a fallback path and `__func__` injection. This is unnecessary — use `drm_err()` / `drm_dbg()` or plain `dev_err()`. The DRM device should be the center of lifecycle management.

```c
+#define qda_err(qdev, fmt, ...) do { \
+	struct device *__dev = qda_get_log_device(qdev); \
+	if (__dev) \
+		dev_err(__dev, "[%s] " fmt, __func__, ##__VA_ARGS__); \
+	else \
+		pr_err(DRIVER_NAME ": [%s] " fmt, __func__, ##__VA_ARGS__); \
+} while (0)
```

- **`atomic_t removing` flag**: Dmitry asked why this is needed when `dev->unplugged` and `drm_dev_enter()`/`drm_dev_exit()` exist. This is reinventing DRM's own unplug infrastructure.

- The `qda_rpmsg_init()` function does nothing except `dev_set_drvdata()` — inline it or remove the abstraction.

- `qda_init_device()` and `qda_deinit_device()` are over-abstracted wrappers around `mutex_init`/`mutex_destroy`.

---
Generated by Claude Code Patch Reviewer