From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: platform/x86/intel/vsec: Decouple add/link helpers from PCI Date: Fri, 27 Feb 2026 14:12:36 +1000 Message-ID: In-Reply-To: <20260224-upstream-pmt-acpi-v5-v5-3-8dd73bcf049c@linux.intel.com> References: <20260224-upstream-pmt-acpi-v5-v5-0-8dd73bcf049c@linux.intel.com> <20260224-upstream-pmt-acpi-v5-v5-3-8dd73bcf049c@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Overall: Good refactor, clean separation.** This removes the `struct pci_dev *pdev` parameter from `intel_vsec_add_aux()` and `intel_vsec_link_devices()`, replacing them with `struct device *parent`. The key safety addition is: ```c if (!dev_is_pci(parent)) return 0; ``` in `intel_vsec_link_devices()`, which correctly short-circuits the dependency-tracking logic (which relies on PCI ID matching) for non-PCI devices. The dependency/linking machinery is only relevant to the VSEC PCI driver's own probe path, so returning 0 for non-PCI parents is correct. The `vsec_tpmi.c` caller update from `vsec_dev->pcidev` to `&vsec_dev->pcidev->dev` is correct given that at this point in the series, `pcidev` still exists. No issues found. --- --- Generated by Claude Code Patch Reviewer