From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: defio: Move variable state into struct fb_deferred_io_state Date: Fri, 27 Feb 2026 15:29:26 +1000 Message-ID: In-Reply-To: <20260224082657.207284-4-tzimmermann@suse.de> References: <20260224082657.207284-1-tzimmermann@suse.de> <20260224082657.207284-4-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean refactoring moving `open_count`, `mapping`, and `pagereflist` from th= e driver-visible `struct fb_deferred_io` to the internal `struct fb_deferre= d_io_state`. **Good improvements:** - `BUG_ON(!info->fbdefio->mapping)` replaced with `fb_WARN_ON_ONCE(info, !f= bdefio_state->mapping)` =E2=80=94 converting BUG_ON to WARN is the right ca= ll here. - `WARN_ON(!list_empty(&fbdefio_state->pagereflist))` added in `fb_deferred= _io_state_release` =E2=80=94 good sanity check. - `INIT_LIST_HEAD(&fbdefio_state->pagereflist)` properly moved to `fb_defer= red_io_state_alloc`. **Minor nit:** The added forward declaration: ```c struct address_space; ``` is technically redundant since `` is already included (whi= ch pulls in `` where `struct address_space` is defined). It's h= armless and documents the dependency, but could be dropped. The removal of `fbdefio->mapping =3D NULL` from `fb_deferred_io_cleanup` is= correct since `mapping` is now in the state struct, and the state's `info`= pointer is set to NULL under the lock, which prevents any access to `mappi= ng` after cleanup. No issues with this patch. --- --- Generated by Claude Code Patch Reviewer