From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: Return GspStaticInfo and FbLayout from boot() Date: Fri, 27 Feb 2026 14:25:28 +1000 Message-ID: In-Reply-To: <20260224225323.3312204-4-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> <20260224225323.3312204-4-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean refactoring. The return type changes from `Result` to `Result<(GetGspStaticInfoReply, FbLayout)>`. The doc comment update is good. Minor: The `// //` trailing comment in the import formatting: ```rust Gsp, // ``` This `//` trailing comment pattern appears throughout the series as a rustfmt workaround. It's a known Rust pattern but might look odd to kernel reviewers unfamiliar with it. In `gpu.rs`, accessing `.0` on the boot result: ```rust gsp_static_info: { gsp.boot(pdev, bar, spec.chipset, gsp_falcon, sec2_falcon)?.0 }, ``` The `FbLayout` (`.1`) is silently discarded here but needed later -- this is fixed in patch 11. Between patches 3 and 11, `FbLayout` is computed and thrown away, which is wasteful. Consider restructuring the series so boot() return value is used immediately. --- Generated by Claude Code Patch Reviewer