Claude review: gpu: nova-core: gsp: make `Cmdq` a pinned type

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

Mechanical change to prepare for `Mutex` in patch 4.

**`#[pin_data]` annotation added:**
```rust
+#[pin_data]
 pub(crate) struct Cmdq {
```

**Constructor returns `PinInit` instead of `Result<Cmdq>`:**
```rust
-    pub(crate) fn new(dev: &device::Device<device::Bound>) -> Result<Cmdq> {
-        let gsp_mem = DmaGspMem::new(dev)?;
-        Ok(Cmdq {
+    pub(crate) fn new(dev: &device::Device<device::Bound>) -> impl PinInit<Self, Error> + '_ {
+        try_pin_init!(Self {
+            gsp_mem: DmaGspMem::new(dev)?,
             dev: dev.into(),
             seq: 0,
-            gsp_mem,
         })
```

**Parent struct uses pin-init syntax:**
```rust
-                cmdq: Cmdq::new(dev)?,
+                cmdq <- Cmdq::new(dev),
```

**Reference update for `GspArgumentsCached::new`:**
```rust
-                    dma_write!(rmargs[0].inner = fw::GspArgumentsCached::new(cmdq))?;
+                    dma_write!(rmargs[0].inner = fw::GspArgumentsCached::new(&cmdq))?;
```
Correct — after pin-init, `cmdq` is accessed by reference via the pin projection, so the explicit `&` is needed.

Straightforward and correct. **Reviewed-by worthy.**

---

---
Generated by Claude Code Patch Reviewer