From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: Clean up S6E3HA2 config dependencies and fill help text Date: Fri, 27 Feb 2026 12:17:12 +1000 Message-ID: In-Reply-To: <20260226-panel-clean-up-kconfig-dep-v1-3-bb28a2355b4c@ixit.cz> References: <20260226-panel-clean-up-kconfig-dep-v1-0-bb28a2355b4c@ixit.cz> <20260226-panel-clean-up-kconfig-dep-v1-3-bb28a2355b4c@ixit.cz> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author:** David Heidelberg **Subject line typo:** The subject says "S6E3HA**2**" but the patch modifies `DRM_PANEL_SAMSUNG_S6E3HA**8**`. The Fixes tag correctly references the S6E3HA8 commit (`779679d3c164`), and the added help text correctly says "Samsung S6E3HA8 DDIC". The subject should read "S6E3HA8". **Misleading commit message:** The commit message says: > As per the config name this Display IC features a DSI command-mode interface But the Kconfig entry it modifies is: ``` tristate "Samsung S6E3HA8 DSI video mode panel" ``` And the driver sets video-mode flags: ```c dsi->mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET; ``` The commit message appears to be copy-pasted from the SOFEF00 patch (patch 1) without being adapted. The justification for removing `select VIDEOMODE_HELPERS` still holds - the driver doesn't use `display_timing`/`videomode` structs regardless of whether it's video or command mode - but the commit message should be corrected to avoid confusion. The help text addition is a nice improvement: ``` + Say Y or M here if you want to enable support for the + Samsung S6E3HA8 DDIC and connected MIPI DSI panel. + Currently supported panels: + + Samsung AMB577PX01 (found in the Samsung S9 smartphone) ``` The substantive changes (remove `select VIDEOMODE_HELPERS`, add `depends on GPIOLIB`) are correct. **Minor nit:** There's a trailing blank line after the panel list in the help text (two blank lines before the next `config` entry). Not a functional issue but slightly inconsistent with typical Kconfig style. **Requested: Fix subject line from "S6E3HA2" to "S6E3HA8", and update commit message to not claim command-mode for a video-mode panel.** --- --- Generated by Claude Code Patch Reviewer