From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: msm: Document DSI controller and DSI PHY on SC8280XP
Date: Tue, 03 Mar 2026 14:28:31 +1000 [thread overview]
Message-ID: <review-patch3-20260228101907.18043-4-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20260228101907.18043-4-mitltlatltl@gmail.com>
Patch Review
**Status: Looks good with a minor note**
Adds `patternProperties` for DSI controller and PHY child nodes to the sc8280xp-mdss binding, plus extends the example with DPU output port endpoints for DSI0 and DSI1.
The patternProperties look correctly structured:
```yaml
+ "^dsi@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ contains:
+ const: qcom,sc8280xp-dsi-ctrl
```
The example additions add `port@1` and `port@2` for the DPU output ports connecting to DSI0 and DSI1 respectively, which is consistent with the actual DTS in patch 4. The example endpoint labels (`dpu_intf1_out`, `dpu_intf2_out`, `mdss0_dsi0_in`, `mdss0_dsi1_in`) match the convention used in the DTS.
**Minor**: The example could be more complete by including skeleton DSI/PHY child nodes to match the new `patternProperties`, but this isn't strictly required for binding validation.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 4:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 10:19 [PATCH v2 0/4] Add DSI display support for SC8280XP Pengyu Luo
2026-02-28 10:19 ` [PATCH v2 1/4] dt-bindings: display: msm-dsi-phy-7nm: Add SC8280XP Pengyu Luo
2026-03-03 4:28 ` Claude review: " Claude Code Review Bot
2026-02-28 10:19 ` [PATCH v2 2/4] dt-bindings: display/msm: dsi-controller-main: " Pengyu Luo
2026-03-03 4:28 ` Claude review: " Claude Code Review Bot
2026-02-28 10:19 ` [PATCH v2 3/4] dt-bindings: display: msm: Document DSI controller and DSI PHY on SC8280XP Pengyu Luo
2026-03-03 4:28 ` Claude Code Review Bot [this message]
2026-02-28 10:19 ` [PATCH v2 4/4] arm64: dts: qcom: sc8280xp: Add dsi nodes " Pengyu Luo
2026-02-28 13:31 ` Dmitry Baryshkov
2026-02-28 13:57 ` Pengyu Luo
2026-02-28 14:23 ` Dmitry Baryshkov
2026-03-01 3:49 ` Pengyu Luo
2026-03-03 4:28 ` Claude review: " Claude Code Review Bot
2026-03-03 4:28 ` Claude review: Add DSI display support for SC8280XP Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-08 6:48 [PATCH v4 0/4] " Pengyu Luo
2026-03-08 6:48 ` [PATCH v4 3/4] dt-bindings: display: msm: Document DSI controller and DSI PHY on SC8280XP Pengyu Luo
2026-03-08 21:56 ` Claude review: " Claude Code Review Bot
2026-02-28 14:17 [PATCH v3 0/4] Add DSI display support for SC8280XP Pengyu Luo
2026-02-28 14:17 ` [PATCH v3 3/4] dt-bindings: display: msm: Document DSI controller and DSI PHY on SC8280XP Pengyu Luo
2026-03-03 4:16 ` Claude review: " Claude Code Review Bot
2026-02-25 5:45 [PATCH 0/5] Add DSI display support for SC8280XP Pengyu Luo
2026-02-25 5:45 ` [PATCH 3/5] dt-bindings: display: msm: Document DSI controller and DSI PHY on SC8280XP Pengyu Luo
2026-02-27 4:04 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260228101907.18043-4-mitltlatltl@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox