From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: msm: Document DSI controller and DSI PHY on SC8280XP Date: Tue, 03 Mar 2026 14:28:31 +1000 Message-ID: In-Reply-To: <20260228101907.18043-4-mitltlatltl@gmail.com> References: <20260228101907.18043-1-mitltlatltl@gmail.com> <20260228101907.18043-4-mitltlatltl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good with a minor note** Adds `patternProperties` for DSI controller and PHY child nodes to the sc8280xp-mdss binding, plus extends the example with DPU output port endpoints for DSI0 and DSI1. The patternProperties look correctly structured: ```yaml + "^dsi@[0-9a-f]+$": + type: object + additionalProperties: true + properties: + compatible: + contains: + const: qcom,sc8280xp-dsi-ctrl ``` The example additions add `port@1` and `port@2` for the DPU output ports connecting to DSI0 and DSI1 respectively, which is consistent with the actual DTS in patch 4. The example endpoint labels (`dpu_intf1_out`, `dpu_intf2_out`, `mdss0_dsi0_in`, `mdss0_dsi1_in`) match the convention used in the DTS. **Minor**: The example could be more complete by including skeleton DSI/PHY child nodes to match the new `patternProperties`, but this isn't strictly required for binding validation. --- --- Generated by Claude Code Patch Reviewer