From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm: Extract code for attempting allocation in a place
Date: Tue, 03 Mar 2026 13:29:38 +1000 [thread overview]
Message-ID: <review-patch3-20260302-dmemcg-aggressive-protect-v5-3-ffd3a2602309@gmx.de> (raw)
In-Reply-To: <20260302-dmemcg-aggressive-protect-v5-3-ffd3a2602309@gmx.de>
Patch Review
**Purpose:** Refactoring — extracts allocation-attempt logic into `ttm_bo_alloc_at_place()` and introduces `struct ttm_bo_alloc_state` to track allocation state across attempts.
**Bug — compile error:**
```c
if (ret == -EBUSY)
continue;
else if (ret)
return;
```
This `return;` in a function returning `int` is a compile error. It should be `return ret;`. While patch 4 restructures this code and happens to fix it, **this patch will not compile standalone**, breaking bisectability. This must be fixed — each patch in a series should compile cleanly.
The `ttm_bo_alloc_state` struct and return-code convention (-EBUSY = retry with eviction, -ENOSPC = skip this place) is a clean abstraction. The doc comment on `ttm_bo_alloc_at_place()` clearly documents the return values.
The `-EAGAIN` to `-EBUSY`/`-ENOSPC` translation is well-commented:
```c
/*
* -EAGAIN means the charge failed, which we treat like an
* allocation failure.
*/
if (ret == -EAGAIN)
return may_evict ? -EBUSY : -ENOSPC;
```
Reviewed-by from Tvrtko is present. The `return;` bug may have been introduced after that review.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 3:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 12:37 [PATCH v5 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-03-02 12:37 ` [PATCH v5 1/6] cgroup/dmem: Add queries for protection values Natalie Vock
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 2/6] cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper Natalie Vock
2026-03-02 14:38 ` Maarten Lankhorst
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-03-02 15:08 ` Tvrtko Ursulin
2026-03-03 3:29 ` Claude Code Review Bot [this message]
2026-03-02 12:37 ` [PATCH v5 4/6] drm/ttm: Split cgroup charge and resource allocation Natalie Vock
2026-03-02 15:25 ` Tvrtko Ursulin
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-03-02 17:02 ` Tvrtko Ursulin
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-03 3:29 ` Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-13 11:39 [PATCH v6 0/6] " Natalie Vock
2026-03-13 11:40 ` [PATCH v6 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-03-13 21:10 ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 [PATCH v4 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-02-25 12:10 ` [PATCH v4 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-02-27 3:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260302-dmemcg-aggressive-protect-v5-3-ffd3a2602309@gmx.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox