From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vt: Store font in struct vc_font Date: Tue, 03 Mar 2026 13:19:14 +1000 Message-ID: In-Reply-To: <20260302141255.518657-4-tzimmermann@suse.de> References: <20260302141255.518657-1-tzimmermann@suse.de> <20260302141255.518657-4-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Introduces `struct vc_font` with `const unsigned char *data` to replace the= UAPI `struct console_font` in `struct vc_data`. Includes good documentatio= n of the font data format. Minor nit =E2=80=94 the doc comment has a typo at line 982 of the mbox: ```c * The field @data points to the first glphy's first byte. ``` "glphy" should be "glyph". The cast in bitblit.c is reasonable: ```c if (par->cursor_state.image.data !=3D (const char *)src || ``` This is needed because `cursor_state.image.data` is `const char *` while `s= rc` is now `const u8 *`. The alignment change in `fbcon.h`: ```c - u8 *fontbuffer; - u8 *fontdata; + u8 *fontbuffer; + const u8 *fontdata; ``` This introduces inconsistent alignment with the surrounding fields (`cursor= _src`, `cursor_size`, etc.). Consider keeping the original alignment style = or aligning all fields consistently. --- Generated by Claude Code Patch Reviewer