From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Support setting custom background color Date: Wed, 04 Mar 2026 06:54:47 +1000 Message-ID: In-Reply-To: <20260303-rk3588-bgcolor-v8-3-fee377037ad1@collabora.com> References: <20260303-rk3588-bgcolor-v8-0-fee377037ad1@collabora.com> <20260303-rk3588-bgcolor-v8-3-fee377037ad1@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good** Clean, minimal implementation. Since VKMS uses 16-bit internal pixel representation, using the full-precision `DRM_ARGB64_GET{R,G,B}()` macros is the right choice: ```c + const struct pixel_argb_u16 background_color = { + .a = 0xffff, + .r = DRM_ARGB64_GETR(bgcolor), + .g = DRM_ARGB64_GETG(bgcolor), + .b = DRM_ARGB64_GETB(bgcolor), + }; ``` Alpha is hardcoded to `0xffff` (opaque), which is documented in the commit message. The attachment in `vkms_crtc_init()` is properly placed after CRTC initialization. Having VKMS support this property is valuable for testing without requiring specific hardware. R-b from Louis Chauvet (VKMS maintainer) is appropriate. --- --- Generated by Claude Code Patch Reviewer