From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: imx93: Add parallel display output nodes
Date: Wed, 04 Mar 2026 07:36:20 +1000 [thread overview]
Message-ID: <review-patch3-20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de> (raw)
In-Reply-To: <20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de>
Patch Review
This patch adds DT nodes for the DPI bridge (inside `media_blk_ctrl`) and the LCDIF display controller, plus stubs for LDB and DSI endpoints on imx93.
**1. `assigned-clock-rates` has only 2 entries for 3 assigned clocks:**
```dts
assigned-clocks = <&clk IMX93_CLK_MEDIA_AXI>,
<&clk IMX93_CLK_MEDIA_APB>,
<&clk IMX93_CLK_MEDIA_DISP_PIX>;
assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1>,
<&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>,
<&clk IMX93_CLK_VIDEO_PLL>;
assigned-clock-rates = <400000000>, <133333333>;
```
Three clocks are listed, three parents are specified, but only two rates. This is valid DT — omitted trailing rates mean "don't set a rate, just reparent." For `MEDIA_DISP_PIX` the rate is presumably determined by the mode, so only the parent is set. This is correct.
**2. Empty endpoint for output port:**
```dts
port@1 {
reg = <1>;
dpi_to_panel: endpoint {
};
};
```
The output endpoint is left empty for board-level DTS files to fill in via `&dpi_to_panel` overrides. This is standard practice.
**3. LCDIF node placement and structure looks correct.** It's a sibling of `media_blk_ctrl` as expected and properly references the LCDIF-specific clocks and power domain.
**4. The imx93.dtsi additions** add stubs for LDB and DSI endpoints with correct reg values (1, 2), preparing for future LVDS and MIPI-DSI bridge support. Clean and forward-looking.
**5. Minor: the `dpi_bridge` label uses underscore while the node name `dpi-bridge` uses hyphen.** This is standard DT convention (labels use underscores, node names use hyphens), so no issue.
Overall, the DTS additions look correct and follow i.MX device tree conventions.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 21:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:34 [PATCH v11 0/3] Add i.MX91/93 parallel display support Marco Felsch
2026-03-03 10:34 ` [PATCH v11 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example Marco Felsch
2026-03-03 21:00 ` Frank Li
2026-03-03 21:36 ` Claude review: " Claude Code Review Bot
2026-03-03 10:34 ` [PATCH v11 2/3] drm/bridge: imx: Add i.MX93 parallel display format configuration support Marco Felsch
2026-03-03 21:00 ` Frank Li
2026-03-03 21:22 ` Marco Felsch
2026-03-03 21:36 ` Claude review: " Claude Code Review Bot
2026-03-03 10:34 ` [PATCH v11 3/3] arm64: dts: imx93: Add parallel display output nodes Marco Felsch
2026-03-03 10:42 ` Marco Felsch
2026-03-03 15:45 ` Frank Li
2026-03-03 15:50 ` Marco Felsch
2026-03-03 21:36 ` Claude Code Review Bot [this message]
2026-03-03 21:36 ` Claude review: Add i.MX91/93 parallel display support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-02 16:10 [PATCH v10 0/3] " Marco Felsch
2026-03-02 16:10 ` [PATCH v10 3/3] arm64: dts: imx93: Add parallel display output nodes Marco Felsch
2026-03-03 3:09 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox