From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: imx93: Add parallel display output nodes
Date: Wed, 04 Mar 2026 07:36:20 +1000
Message-ID: <review-patch3-20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de>
In-Reply-To: <20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de>
References: <20260303-v6-18-topic-imx93-parallel-display-v11-0-1b03733c8461@pengutronix.de> <20260303-v6-18-topic-imx93-parallel-display-v11-3-1b03733c8461@pengutronix.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

This patch adds DT nodes for the DPI bridge (inside `media_blk_ctrl`) and t=
he LCDIF display controller, plus stubs for LDB and DSI endpoints on imx93.

**1. `assigned-clock-rates` has only 2 entries for 3 assigned clocks:**

```dts
assigned-clocks =3D <&clk IMX93_CLK_MEDIA_AXI>,
		  <&clk IMX93_CLK_MEDIA_APB>,
		  <&clk IMX93_CLK_MEDIA_DISP_PIX>;
assigned-clock-parents =3D <&clk IMX93_CLK_SYS_PLL_PFD1>,
			 <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>,
			 <&clk IMX93_CLK_VIDEO_PLL>;
assigned-clock-rates =3D <400000000>, <133333333>;
```

Three clocks are listed, three parents are specified, but only two rates. T=
his is valid DT =E2=80=94 omitted trailing rates mean "don't set a rate, ju=
st reparent." For `MEDIA_DISP_PIX` the rate is presumably determined by the=
 mode, so only the parent is set. This is correct.

**2. Empty endpoint for output port:**

```dts
port@1 {
	reg =3D <1>;

	dpi_to_panel: endpoint {
	};
};
```

The output endpoint is left empty for board-level DTS files to fill in via =
`&dpi_to_panel` overrides. This is standard practice.

**3. LCDIF node placement and structure looks correct.** It's a sibling of =
`media_blk_ctrl` as expected and properly references the LCDIF-specific clo=
cks and power domain.

**4. The imx93.dtsi additions** add stubs for LDB and DSI endpoints with co=
rrect reg values (1, 2), preparing for future LVDS and MIPI-DSI bridge supp=
ort. Clean and forward-looking.

**5. Minor: the `dpi_bridge` label uses underscore while the node name `dpi=
-bridge` uses hyphen.** This is standard DT convention (labels use undersco=
res, node names use hyphens), so no issue.

Overall, the DTS additions look correct and follow i.MX device tree convent=
ions.

---
Generated by Claude Code Patch Reviewer