From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: dma: add zeroed constructor to `Coherent`
Date: Wed, 04 Mar 2026 07:03:02 +1000
Message-ID: <review-patch3-20260303162314.94363-4-dakr@kernel.org>
In-Reply-To: <20260303162314.94363-4-dakr@kernel.org>
References: <20260303162314.94363-1-dakr@kernel.org> <20260303162314.94363-4-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Typo in doc comment**:
```rust
/// Unlike `Coherent::<[T; N]>::zeroed_with_attrs`, `Coherent::<T>::zeored_slices` support
```
"zeored_slices" should be "zeroed_slice".

The `__GFP_ZERO` flag is ORed into the caller-provided `gfp_flags` in `zeroed_with_attrs` and then passed to `alloc_with_attrs`. This is correct since `dma_alloc_coherent` respects `__GFP_ZERO`.

No other issues. The constructor hierarchy is clean.

---
Generated by Claude Code Patch Reviewer