From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: fsl-ldb: Add support for i.MX94
Date: Thu, 05 Mar 2026 13:34:48 +1000 [thread overview]
Message-ID: <review-patch3-20260304-dcif-upstreaming-v8-3-bec5c047edd4@oss.nxp.com> (raw)
In-Reply-To: <20260304-dcif-upstreaming-v8-3-bec5c047edd4@oss.nxp.com>
Patch Review
Adds `max_clk_khz` to the devdata struct and uses it in `fsl_ldb_mode_valid()` instead of the previously hardcoded 80000 kHz. The i.MX94 supports 165 MHz.
The change from:
```c
if (mode->clock > (fsl_ldb_is_dual(fsl_ldb) ? 160000 : 80000))
```
to:
```c
if (mode->clock > (fsl_ldb_is_dual(fsl_ldb) ? 2 : 1) * fsl_ldb->devdata->max_clk_khz)
```
is correct and clean. Note the i.MX94 register offsets (`ldb_ctrl = 0x04`, `lvds_ctrl = 0x08`) are different from the other variants — this is because it's nested inside the LVDS CSR syscon as a child node, so offsets are relative to the child's reg.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-05 3:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 11:34 [PATCH v8 0/9] Add support for i.MX94 DCIF Laurentiu Palcu
2026-03-04 11:34 ` [PATCH v8 1/9] dt-bindings: display: fsl,ldb: Add i.MX94 LDB Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-04 11:34 ` [PATCH v8 2/9] drm/bridge: fsl-ldb: Get the next non-panel bridge Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-04 11:34 ` [PATCH v8 3/9] drm/bridge: fsl-ldb: Add support for i.MX94 Laurentiu Palcu
2026-03-05 3:34 ` Claude Code Review Bot [this message]
2026-03-04 11:34 ` [PATCH v8 4/9] dt-bindings: display: imx: Add i.MX94 DCIF Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-04 11:34 ` [PATCH v8 5/9] drm/imx: Add support for " Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-04 11:34 ` [PATCH v8 6/9] dt-bindings: clock: nxp, imx95-blk-ctl: Add ldb child node Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-04 11:34 ` [PATCH v8 7/9] arm64: dts: imx943: Add display pipeline nodes Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-04 11:34 ` [PATCH v8 8/9] arm64: dts: imx943-evk: Add display support using IT6263 Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-04 11:34 ` [PATCH v8 9/9] MAINTAINERS: Add entry for i.MX94 DCIF driver Laurentiu Palcu
2026-03-05 3:34 ` Claude review: " Claude Code Review Bot
2026-03-05 3:34 ` Claude review: Add support for i.MX94 DCIF Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260304-dcif-upstreaming-v8-3-bec5c047edd4@oss.nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox