public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/xe_hw_error: Integrate DRM RAS with hardware error handling
Date: Thu, 05 Mar 2026 13:47:41 +1000	[thread overview]
Message-ID: <review-patch3-20260304074412.464435-10-riana.tauro@intel.com> (raw)
In-Reply-To: <20260304074412.464435-10-riana.tauro@intel.com>

Patch Review

**Concern: Lost diagnostic specificity in error messages**

The original code distinguished CORRECTABLE, NONFATAL, and FATAL in its log strings (e.g. `HEC_ERR_STATUS_NONFATAL`). The new code maps both NONFATAL and FATAL to the same severity string "uncorrectable-errors":

```c
static enum drm_xe_ras_error_severity hw_err_to_severity(const enum hardware_error hw_err)
{
    if (hw_err == HARDWARE_ERROR_CORRECTABLE)
        return DRM_XE_RAS_ERR_SEV_CORRECTABLE;
    return DRM_XE_RAS_ERR_SEV_UNCORRECTABLE;
}
```

This means log messages no longer distinguish FATAL from NONFATAL hardware errors, which is a regression in debuggability. The log message `"HEC FW %s %s reported"` will say "uncorrectable-errors" for both fatal and nonfatal, making it harder for engineers to triage.

**Minor: `hw_error_info_init` silently skips non-PVC**

```c
static int hw_error_info_init(struct xe_device *xe)
{
    if (xe->info.platform != XE_PVC)
        return 0;
    return xe_drm_ras_init(xe);
}
```

This is fine but means the `xe_hw_error_init` flow will call `process_hw_errors` on non-PVC platforms without RAS info initialized, so the `info` pointer check in patch 4's `hw_error_source_handler` (`if (!info) goto clear_reg`) becomes load-bearing.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-05  3:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  7:44 [PATCH v10 0/5] Introduce DRM_RAS using generic netlink for RAS Riana Tauro
2026-03-04  7:44 ` [PATCH v10 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 2/5] drm/xe/xe_drm_ras: Add support for XE DRM RAS Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 3/5] drm/xe/xe_hw_error: Integrate DRM RAS with hardware error handling Riana Tauro
2026-03-05  3:47   ` Claude Code Review Bot [this message]
2026-03-04  7:44 ` [PATCH v10 4/5] drm/xe/xe_hw_error: Add support for Core-Compute errors Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 5/5] drm/xe/xe_hw_error: Add support for PVC SoC errors Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-05  3:47 ` Claude review: Introduce DRM_RAS using generic netlink for RAS Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-28  8:08 [PATCH v9 0/5] " Riana Tauro
2026-02-28  8:08 ` [PATCH v9 3/5] drm/xe/xe_hw_error: Integrate DRM RAS with hardware error handling Riana Tauro
2026-03-03  4:32   ` Claude review: " Claude Code Review Bot
2026-02-23  6:05 [PATCH v8 0/5] Introduce DRM_RAS using generic netlink for RAS Riana Tauro
2026-02-23  6:05 ` [PATCH v8 3/5] drm/xe/xe_hw_error: Integrate DRM RAS with hardware error handling Riana Tauro
2026-02-24  0:45   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260304074412.464435-10-riana.tauro@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox