From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Refcount v3d_stats
Date: Mon, 09 Mar 2026 09:20:15 +1000 [thread overview]
Message-ID: <review-patch3-20260305-v3d-reset-locking-improv-v2-3-fd53c91f7726@igalia.com> (raw)
In-Reply-To: <20260305-v3d-reset-locking-improv-v2-3-fd53c91f7726@igalia.com>
Patch Review
This is the core change of the series. The design is sound: `v3d_stats` gets a `kref` and is heap-allocated via `v3d_stats_alloc()`.
The error handling in `v3d_open` is correct — the two-label approach (`err_sched` / `err_stats`) properly handles the case where stats were allocated but `drm_sched_entity_init` failed:
```c
err_sched:
v3d_stats_put(v3d_priv->stats[i]);
err_stats:
for (i--; i >= 0; i--) {
drm_sched_entity_destroy(&v3d_priv->sched_entity[i]);
v3d_stats_put(v3d_priv->stats[i]);
}
```
The `v3d_gem_init` error handling is also correctly reworked — previous bare `return -ENOMEM` / `return ret` paths that leaked stats are now routed through proper cleanup labels. The reordering that separates `drm_mm_takedown` from the DMA alloc failure path (`err_dma_alloc` vs `err_sched`) is correct.
One observation: `v3d_stats_release` and `v3d_stats_alloc` are placed in `v3d_sched.c` rather than, say, `v3d_drv.c` where `v3d_get_stats` lives. This is fine since `v3d_sched.c` is the primary consumer, but worth noting for future reference.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 23:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 23:25 [PATCH v2 0/6] drm/v3d: Improve v3d_stats lifetime and locking Maíra Canal
2026-03-05 23:25 ` [PATCH v2 1/6] drm/v3d: Handle error from drm_sched_entity_init() Maíra Canal
2026-03-08 23:20 ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 2/6] drm/v3d: Use raw seqcount helpers instead of fighting with lockdep Maíra Canal
2026-03-08 23:20 ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 3/6] drm/v3d: Refcount v3d_stats Maíra Canal
2026-03-08 23:20 ` Claude Code Review Bot [this message]
2026-03-05 23:25 ` [PATCH v2 4/6] drm/v3d: Hold v3d_stats references in each job Maíra Canal
2026-03-08 23:20 ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 5/6] drm/v3d: Attach per-fd reset counters to v3d_stats Maíra Canal
2026-03-08 23:20 ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 6/6] drm/v3d: Remove dedicated fence_lock Maíra Canal
2026-03-08 23:20 ` Claude review: " Claude Code Review Bot
2026-03-08 23:20 ` Claude review: drm/v3d: Improve v3d_stats lifetime and locking Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-06 11:30 [PATCH v3 0/6] " Maíra Canal
2026-03-06 11:30 ` [PATCH v3 3/6] drm/v3d: Refcount v3d_stats Maíra Canal
2026-03-08 22:56 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260305-v3d-reset-locking-improv-v2-3-fd53c91f7726@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox