From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Drop redundant properties
Date: Mon, 09 Mar 2026 08:53:19 +1000 [thread overview]
Message-ID: <review-patch3-20260306-dt-bindings-display-panel-clean-v1-3-3086eda1efaf@oss.qualcomm.com> (raw)
In-Reply-To: <20260306-dt-bindings-display-panel-clean-v1-3-3086eda1efaf@oss.qualcomm.com>
Patch Review
This is the largest patch, removing redundant `": true"` property declarations from 22 bindings. The logic is sound: bindings that use `$ref: panel-common.yaml#` combined with `unevaluatedProperties: false` already inherit all properties from the common schema. Properties like `port`, `reset-gpios`, `backlight`, `power-supply`, `label`, `rotation`, and `display-timings` are all defined in `panel-common.yaml` and don't need to be re-declared.
I verified several files (e.g., `abt,y030xx067a.yaml`, `sitronix,st7701.yaml`) and confirmed they use `unevaluatedProperties: false` with `$ref: panel-common.yaml#`, making the removed declarations truly redundant.
One subtle point worth noting: `samsung,s6e63m0.yaml` retains `default-brightness: true` and `max-brightness: true` after removing `reset-gpios: true` and `port: true`. This is correct since `default-brightness` and `max-brightness` are NOT in `panel-common.yaml` (they're panel-specific extensions). No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 22:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 1/5] dt-bindings: display: samsung,s6d7aa0: Document port Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 3/5] dt-bindings: display: panel: Drop redundant properties Krzysztof Kozlowski
2026-03-08 22:53 ` Claude Code Review Bot [this message]
2026-03-06 12:02 ` [PATCH 4/5] dt-bindings: display: panel: Align style of additionalProperties Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-08 22:53 ` Claude review: dt-bindings: display: panel: Few cleanups and fixes Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260306-dt-bindings-display-panel-clean-v1-3-3086eda1efaf@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox