From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Drop redundant properties Date: Mon, 09 Mar 2026 08:53:19 +1000 Message-ID: In-Reply-To: <20260306-dt-bindings-display-panel-clean-v1-3-3086eda1efaf@oss.qualcomm.com> References: <20260306-dt-bindings-display-panel-clean-v1-0-3086eda1efaf@oss.qualcomm.com> <20260306-dt-bindings-display-panel-clean-v1-3-3086eda1efaf@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the largest patch, removing redundant `": true"` property declarations from 22 bindings. The logic is sound: bindings that use `$ref: panel-common.yaml#` combined with `unevaluatedProperties: false` already inherit all properties from the common schema. Properties like `port`, `reset-gpios`, `backlight`, `power-supply`, `label`, `rotation`, and `display-timings` are all defined in `panel-common.yaml` and don't need to be re-declared. I verified several files (e.g., `abt,y030xx067a.yaml`, `sitronix,st7701.yaml`) and confirmed they use `unevaluatedProperties: false` with `$ref: panel-common.yaml#`, making the removed declarations truly redundant. One subtle point worth noting: `samsung,s6e63m0.yaml` retains `default-brightness: true` and `max-brightness: true` after removing `reset-gpios: true` and `port: true`. This is correct since `default-brightness` and `max-brightness` are NOT in `panel-common.yaml` (they're panel-specific extensions). No issues. --- Generated by Claude Code Patch Reviewer