From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vgaarb: mark vga_get() and wrappers as __must_check Date: Mon, 09 Mar 2026 08:05:36 +1000 Message-ID: In-Reply-To: <20260307173538.763188-4-Simon.Richter@hogyros.de> References: <20260307173538.763188-1-Simon.Richter@hogyros.de> <20260307173538.763188-4-Simon.Richter@hogyros.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good.** Straightforward annotation change. All three functions (`vga_get()`, `vga_get_interruptible()`, `vga_get_uninterruptible()`) and their `!CONFIG_VGA_ARB` stubs are annotated. This will cause compile warnings for any in-tree callers that ignore the return value, which is the right approach given patches 1 and 2 now make these errors meaningful. The cover letter mentions companion i915/xe patches to handle the new warnings, which makes sense since those drivers call `vga_get_uninterruptible()`. --- Generated by Claude Code Patch Reviewer