From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vt: Store font in struct vc_font Date: Tue, 10 Mar 2026 12:19:43 +1000 Message-ID: In-Reply-To: <20260309141723.137364-4-tzimmermann@suse.de> References: <20260309141723.137364-1-tzimmermann@suse.de> <20260309141723.137364-4-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Introduces `struct vc_font` as a kernel-internal replacement for the UAPI `= struct console_font`. Good separation of concerns. Minor nit: In `bitblit.c`: ```c - if (par->cursor_state.image.data !=3D src || + if (par->cursor_state.image.data !=3D (const char *)src || ``` `par->cursor_state.image.data` is `const char *` while `src` is now `const = u8 *`. The explicit cast works but suggests a type mismatch worth a comment= or a more principled fix (e.g., making `image.data` use `const u8 *`). Also in `fbcon.h`: ```c - u8 *fontbuffer; - u8 *fontdata; + u8 *fontbuffer; + const u8 *fontdata; ``` The alignment change to `fontbuffer` is gratuitous whitespace churn =E2=80= =94 only `fontdata` needed the const change. --- Generated by Claude Code Patch Reviewer