public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mediatek: Set dedicated DMA device and drop custom GEM callbacks
Date: Wed, 11 Mar 2026 13:45:58 +1000	[thread overview]
Message-ID: <review-patch3-20260310032511.2545500-4-wenst@chromium.org> (raw)
In-Reply-To: <20260310032511.2545500-4-wenst@chromium.org>

Patch Review

This is the main payoff patch, deleting the entire `mtk_gem.c` (231 lines) and `mtk_gem.h` (17 lines) files. The key changes:

1. Replaces the per-private-data `dma_dev` loop with a single `drm_dev_set_dma_dev(drm, dma_dev)` call:
```c
-	for (i = 0; i < private->data->mmsys_dev_num; i++)
-		private->all_drm_private[i]->dma_dev = dma_dev;
+	drm_dev_set_dma_dev(drm, dma_dev);
```

2. Replaces custom driver ops with `DRM_GEM_DMA_DRIVER_OPS`:
```c
-	.dumb_create = mtk_gem_dumb_create,
+	DRM_GEM_DMA_DRIVER_OPS,
 	DRM_FBDEV_DMA_DRIVER_OPS,
-
-	.gem_prime_import = mtk_gem_prime_import,
-	.gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
```

**Minor observation**: The old `mtk_gem_dumb_create` had a manual pitch calculation with `DIV_ROUND_UP(args->width * args->bpp, 8)` and explicit overflow-safe size computation (`args->size = args->pitch; args->size *= args->height`). The new `drm_gem_dma_dumb_create` uses `drm_mode_size_dumb()` which should handle this equivalently. This is fine.

**Minor observation**: As the commit message notes, the old mmap helper set `VM_IO | VM_DONTDUMP` flags that the standard GEM DMA mmap helper does not set. The commit message correctly argues that `VM_IO` doesn't make sense for `dma_alloc_attrs()` buffers. `VM_DONTDUMP` absence means these mappings will now appear in core dumps, which is a very minor behavioral change but acceptable.

No blocking issues.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-11  3:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  3:25 [PATCH RESEND 0/4] drm/gem-dma: Support dedicated DMA device for allocation Chen-Yu Tsai
2026-03-10  3:25 ` [PATCH RESEND 1/4] drm/prime: Limit scatter list size with dedicated DMA device Chen-Yu Tsai
2026-03-10  8:00   ` Thomas Zimmermann
2026-03-11  3:45   ` Claude review: " Claude Code Review Bot
2026-03-10  3:25 ` [PATCH RESEND 2/4] drm/gem-dma: Support dedicated DMA device for allocation and mapping Chen-Yu Tsai
2026-03-10  8:02   ` Thomas Zimmermann
2026-03-11  3:45   ` Claude review: " Claude Code Review Bot
2026-03-10  3:25 ` [PATCH RESEND 3/4] drm/mediatek: Set dedicated DMA device and drop custom GEM callbacks Chen-Yu Tsai
2026-03-10  8:21   ` Thomas Zimmermann
2026-03-11  3:45   ` Claude Code Review Bot [this message]
2026-03-10  3:25 ` [PATCH RESEND 4/4] drm/sun4i: Use backend/mixer as dedicated DMA device Chen-Yu Tsai
2026-03-11  3:45   ` Claude review: " Claude Code Review Bot
2026-03-10  7:56 ` [PATCH RESEND 0/4] drm/gem-dma: Support dedicated DMA device for allocation Thomas Zimmermann
2026-03-11  3:45 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-11  9:49 [PATCH v2 0/4] " Chen-Yu Tsai
2026-03-11  9:49 ` [PATCH v2 3/4] drm/mediatek: Set dedicated DMA device and drop custom GEM callbacks Chen-Yu Tsai
2026-03-11 21:08   ` Claude review: " Claude Code Review Bot
2026-03-10  3:20 [PATCH 0/4] drm/gem-dma: Support dedicated DMA device for allocation Chen-Yu Tsai
2026-03-10  3:20 ` [PATCH 3/4] drm/mediatek: Set dedicated DMA device and drop custom GEM callbacks Chen-Yu Tsai
2026-03-11  3:48   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260310032511.2545500-4-wenst@chromium.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox