From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur Date: Wed, 11 Mar 2026 13:43:35 +1000 Message-ID: In-Reply-To: <20260310033617.3108675-4-sibi.sankar@oss.qualcomm.com> References: <20260310033617.3108675-1-sibi.sankar@oss.qualcomm.com> <20260310033617.3108675-4-sibi.sankar@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Looks correct.** Converts the `compatible` from a plain `enum` to `oneOf` with both the original `enum` and a new `items` variant for `qcom,glymur-fastrpc` falling back to `qcom,kaanapali-fastrpc`. This is the correct YAML pattern for adding a SoC-specific compatible that falls back to another SoC's compatible. Minor style note: The single-item `enum` under `items` could be replaced with a `const`: ```yaml - items: - const: qcom,glymur-fastrpc - const: qcom,kaanapali-fastrpc ``` But the `enum` form is also fine and is commonly used when future SoC compatibles might be added to the same fallback. No change needed. --- Generated by Claude Code Patch Reviewer