From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tyr: Use register! macro for JOB_CONTROL
Date: Fri, 13 Mar 2026 14:38:51 +1000 [thread overview]
Message-ID: <review-patch3-20260311-b4-tyr-use-register-macro-v2-v2-3-b936d9eb8f51@collabora.com> (raw)
In-Reply-To: <20260311-b4-tyr-use-register-macro-v2-v2-3-b936d9eb8f51@collabora.com>
Patch Review
Clean conversion of JOB_CONTROL IRQ registers. The field split into `csg` (bits 30:0) and `glb` (bit 31) matches the hardware spec (CSG slots in the lower bits, global interface in bit 31).
**Renamed: `JOB_IRQ_STAT` → `JOB_IRQ_STATUS`**
The original register was named `JOB_IRQ_STAT`. The new name `JOB_IRQ_STATUS` is more readable and consistent with the GPU_CONTROL naming (`GPU_IRQ_STATUS`). Since `JOB_IRQ_STAT` wasn't used outside `regs.rs`, this is fine.
**No re-export added.** Unlike `gpu_control` which has `pub(super) use gpu_control::*;`, there is no corresponding `pub(super) use job_control::*;` line. Currently these registers are unused in the driver, so this doesn't cause a build error, but it's inconsistent. When these registers are eventually used, they'll need to be accessed via `job_control::JOB_IRQ_RAWSTAT` unless a re-export is added.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 23:03 [PATCH v2 0/5] drm/tyr: Use register! macro Deborah Brouwer
2026-03-11 23:03 ` [PATCH v2 1/5] drm/tyr: Use register! macro for GPU_CONTROL Deborah Brouwer
2026-03-12 8:39 ` Boris Brezillon
2026-03-12 13:25 ` Alexandre Courbot
2026-03-12 9:14 ` Boris Brezillon
2026-03-13 4:38 ` Claude review: " Claude Code Review Bot
2026-03-11 23:03 ` [PATCH v2 2/5] drm/tyr: Set interconnect coherency during probe Deborah Brouwer
2026-03-12 9:07 ` Boris Brezillon
2026-03-13 4:38 ` Claude review: " Claude Code Review Bot
2026-03-11 23:04 ` [PATCH v2 3/5] drm/tyr: Use register! macro for JOB_CONTROL Deborah Brouwer
2026-03-13 4:38 ` Claude Code Review Bot [this message]
2026-03-11 23:04 ` [PATCH v2 4/5] drm/tyr: Use register! macro for MMU_CONTROL Deborah Brouwer
2026-03-12 8:59 ` Boris Brezillon
2026-03-13 4:38 ` Claude review: " Claude Code Review Bot
2026-03-11 23:04 ` [PATCH v2 5/5] drm/tyr: Remove custom register struct Deborah Brouwer
2026-03-13 4:38 ` Claude review: " Claude Code Review Bot
2026-03-11 23:09 ` [PATCH v2 0/5] drm/tyr: Use register! macro Deborah Brouwer
2026-03-12 8:43 ` Boris Brezillon
2026-03-12 8:50 ` Boris Brezillon
2026-03-13 4:38 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-24 0:18 [PATCH v3 00/12] " Deborah Brouwer
2026-03-24 0:18 ` [PATCH v3 04/12] drm/tyr: Use register! macro for JOB_CONTROL Deborah Brouwer
2026-03-24 21:08 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260311-b4-tyr-use-register-macro-v2-v2-3-b936d9eb8f51@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox