From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Use register! macro for JOB_CONTROL Date: Fri, 13 Mar 2026 14:38:51 +1000 Message-ID: In-Reply-To: <20260311-b4-tyr-use-register-macro-v2-v2-3-b936d9eb8f51@collabora.com> References: <20260311-b4-tyr-use-register-macro-v2-v2-0-b936d9eb8f51@collabora.com> <20260311-b4-tyr-use-register-macro-v2-v2-3-b936d9eb8f51@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean conversion of JOB_CONTROL IRQ registers. The field split into `csg` (= bits 30:0) and `glb` (bit 31) matches the hardware spec (CSG slots in the l= ower bits, global interface in bit 31). **Renamed: `JOB_IRQ_STAT` =E2=86=92 `JOB_IRQ_STATUS`** The original register was named `JOB_IRQ_STAT`. The new name `JOB_IRQ_STATU= S` is more readable and consistent with the GPU_CONTROL naming (`GPU_IRQ_ST= ATUS`). Since `JOB_IRQ_STAT` wasn't used outside `regs.rs`, this is fine. **No re-export added.** Unlike `gpu_control` which has `pub(super) use gpu_= control::*;`, there is no corresponding `pub(super) use job_control::*;` li= ne. Currently these registers are unused in the driver, so this doesn't cau= se a build error, but it's inconsistent. When these registers are eventuall= y used, they'll need to be accessed via `job_control::JOB_IRQ_RAWSTAT` unle= ss a re-export is added. --- Generated by Claude Code Patch Reviewer