public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/drm_ras: Add DRM RAS netlink error event notification
Date: Thu, 12 Mar 2026 07:06:13 +1000	[thread overview]
Message-ID: <review-patch3-20260311102913.3387468-9-riana.tauro@intel.com> (raw)
In-Reply-To: <20260311102913.3387468-9-riana.tauro@intel.com>

Patch Review

This is the core event notification infrastructure. The implementation follows standard genl multicast patterns.

**`drm_ras_error_notify` looks correct:**

```c
void drm_ras_error_notify(struct drm_ras_node *node, u32 error_id, gfp_t flags)
{
    ...
    genl_info_init_ntf(&info, &drm_ras_nl_family, DRM_RAS_CMD_ERROR_EVENT);
    msg = genlmsg_new(NLMSG_GOODSIZE, flags);
    ...
    genlmsg_multicast(&drm_ras_nl_family, msg, 0, DRM_RAS_NLGRP_ERROR_NOTIFY, flags);
```

The function properly accepts `gfp_t flags` which is important since it will be called from atomic context (patch 4 calls it with `GFP_ATOMIC`). The error handling with `goto err_cancel` / `goto err_free` is correct.

**`DRM_RAS_NLGRP_ERROR_NOTIFY` placement:**

```c
enum {
    DRM_RAS_NLGRP_ERROR_NOTIFY,
};
```

This enum is defined in `drm_ras_nl.h` which is a driver-internal header. That's fine since the multicast group index is kernel-internal; userspace uses the string name `"error-notify"` to subscribe.

**`EXPORT_SYMBOL` vs `EXPORT_SYMBOL_GPL`:**

```c
EXPORT_SYMBOL(drm_ras_error_notify);
```

The existing RAS framework presumably uses one or the other consistently. If the base series uses `EXPORT_SYMBOL_GPL` for other RAS functions, this should match.

**No validation of `node` or `error_id`:**

The function doesn't validate that `node` is non-NULL or that `error_id` is within range. Since this is a DRM-internal API called only by drivers, this is likely acceptable, but a brief note or `WARN_ON(!node)` might help catch driver bugs.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-11 21:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 10:29 [PATCH 0/4] Add support for clear counter and error event in DRM RAS Riana Tauro
2026-03-11 10:29 ` [PATCH 1/4] drm/drm_ras: Add clear-error-counter netlink command to drm_ras Riana Tauro
2026-03-11 21:06   ` Claude review: " Claude Code Review Bot
2026-03-11 10:29 ` [PATCH 2/4] drm/xe/xe_drm_ras: Add support for clear-error-counter in XE DRM RAS Riana Tauro
2026-03-11 21:06   ` Claude review: " Claude Code Review Bot
2026-03-11 10:29 ` [PATCH 3/4] drm/drm_ras: Add DRM RAS netlink error event notification Riana Tauro
2026-03-11 21:06   ` Claude Code Review Bot [this message]
2026-03-11 10:29 ` [PATCH 4/4] drm/xe/xe_drm_ras: Add error-event support in XE DRM RAS Riana Tauro
2026-03-11 21:06   ` Claude review: " Claude Code Review Bot
2026-03-11 21:06 ` Claude review: Add support for clear counter and error event in " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260311102913.3387468-9-riana.tauro@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox