From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: define helper for MDSS and Adreno drivers Date: Fri, 13 Mar 2026 14:12:49 +1000 Message-ID: In-Reply-To: <20260312-ubwc-rework-v3-3-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-3-b7e8f800176a@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `qcom_ubwc_version_tag()`, `qcom_ubwc_get_ubwc_mode()`, `qcom_ubwc_min_acc_length_64b()`, `qcom_ubwc_macrotile_mode()`, `qcom_ubwc_bank_spread()`, and `qcom_ubwc_swizzle()`. **Style note:** `qcom_ubwc_swizzle()` declares a variable after a `return` statement: ```c if (cfg->ubwc_enc_version == UBWC_1_0) return ...; u32 ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 | ...; ``` Valid C11 but slightly unusual for kernel code. Not a blocker. **Question:** `qcom_ubwc_bank_spread()` always returns `true`. A comment explaining why (e.g., "bank spreading is always enabled per hardware documentation") would be helpful. --- Generated by Claude Code Patch Reviewer