From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Use devm_reset_control_get_optional_exclusive()
Date: Fri, 13 Mar 2026 13:47:07 +1000
Message-ID: <review-patch3-20260312-v3d-power-management-v7-3-9f006a1d4c55@igalia.com>
In-Reply-To: <20260312-v3d-power-management-v7-3-9f006a1d4c55@igalia.com>
References: <20260312-v3d-power-management-v7-0-9f006a1d4c55@igalia.com> <20260312-v3d-power-management-v7-3-9f006a1d4c55@igalia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Straightforward cleanup using the proper `devm_reset_control_get_optional_exclusive()` API. The use of `dev_err_probe()` for error reporting is idiomatic. The separation of the error path (`IS_ERR`) from the absent-reset path (`!v3d->reset`) is cleaner than the previous approach:

```c
+	v3d->reset = devm_reset_control_get_optional_exclusive(dev, NULL);
 	if (IS_ERR(v3d->reset)) {
-		ret = PTR_ERR(v3d->reset);
-
-		if (ret == -EPROBE_DEFER)
-			goto clk_disable;
-
-		v3d->reset = NULL;
+		ret = dev_err_probe(dev, PTR_ERR(v3d->reset),
+				    "Failed to get reset control\n");
+		goto clk_disable;
+	}
+
+	if (!v3d->reset) {
```

Has two Reviewed-by tags. No issues.

---
Generated by Claude Code Patch Reviewer