From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/hisilicon/hibmc: move display contrl config to hibmc_probe()
Date: Fri, 13 Mar 2026 14:23:18 +1000 [thread overview]
Message-ID: <review-patch3-20260312074202.1491504-4-shiyongbang@huawei.com> (raw)
In-Reply-To: <20260312074202.1491504-4-shiyongbang@huawei.com>
Patch Review
**Typo in subject:** "contrl" should be "control".
**Subject is slightly misleading:** The code actually moves the display control config into `hibmc_hw_config()`, which is called from `hibmc_hw_init()`, which is called from `hibmc_probe()`. The subject implies it's directly in `hibmc_probe()` itself.
The code change is clean — it moves the four register bit-sets from the VDAC encoder `mode_set` callback into `hibmc_hw_config()`. This ensures the display control bits are configured during driver initialization regardless of whether VGA output is active. The fix makes sense for the DP-only scenario described.
No functional issues with the code itself.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 7:41 [PATCH RESEND drm-dp 0/4] Fix some bugs in the hibmc driver Yongbang Shi
2026-03-12 7:41 ` [PATCH RESEND drm-dp 1/4] drm/hisilicon/hibmc: add updating link cap in DP detect() Yongbang Shi
2026-03-13 4:23 ` Claude review: " Claude Code Review Bot
2026-03-12 7:42 ` [PATCH RESEND drm-dp 2/4] drm/hisilicon/hibmc: fix no showing when no connectors connected Yongbang Shi
2026-03-13 4:23 ` Claude review: " Claude Code Review Bot
2026-03-12 7:42 ` [PATCH RESEND drm-dp 3/4] drm/hisilicon/hibmc: move display contrl config to hibmc_probe() Yongbang Shi
2026-03-13 4:23 ` Claude Code Review Bot [this message]
2026-03-12 7:42 ` [PATCH RESEND drm-dp 4/4] drm/hisilicon/hibmc: use clock to look up the PLL value Yongbang Shi
2026-03-13 4:23 ` Claude review: " Claude Code Review Bot
2026-03-13 4:23 ` Claude review: Fix some bugs in the hibmc driver Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260312074202.1491504-4-shiyongbang@huawei.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox