From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/hisilicon/hibmc: move display contrl config to hibmc_probe() Date: Fri, 13 Mar 2026 14:23:18 +1000 Message-ID: In-Reply-To: <20260312074202.1491504-4-shiyongbang@huawei.com> References: <20260312074202.1491504-1-shiyongbang@huawei.com> <20260312074202.1491504-4-shiyongbang@huawei.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Typo in subject:** "contrl" should be "control". **Subject is slightly misleading:** The code actually moves the display con= trol config into `hibmc_hw_config()`, which is called from `hibmc_hw_init()= `, which is called from `hibmc_probe()`. The subject implies it's directly = in `hibmc_probe()` itself. The code change is clean =E2=80=94 it moves the four register bit-sets from= the VDAC encoder `mode_set` callback into `hibmc_hw_config()`. This ensure= s the display control bits are configured during driver initialization rega= rdless of whether VGA output is active. The fix makes sense for the DP-only= scenario described. No functional issues with the code itself. --- Generated by Claude Code Patch Reviewer