public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/pagemap: Correct cpages calculation for migrate_vma_setup
Date: Fri, 13 Mar 2026 14:02:32 +1000	[thread overview]
Message-ID: <review-patch3-20260312151726.1779566-4-francois.dugast@intel.com> (raw)
In-Reply-To: <20260312151726.1779566-4-francois.dugast@intel.com>

Patch Review

The fix is conceptually correct — `migrate.cpages` after `migrate_vma_setup` counts folios, not base pages, so a single 2M THP would report cpages=1 while npages=512.

**Issue: Return type mismatch.** The function returns `int` but the internal counter `cpages` is `unsigned long`, and it's compared against `npages` which is also `unsigned long`:

```c
+static int drm_pagemap_cpages(unsigned long *migrate_pfn, unsigned long npages)
+{
+	unsigned long i, cpages = 0;
```

The return should be `unsigned long` to avoid potential truncation on 64-bit systems with very large migration ranges. In practice this may never trigger (migrations are bounded), but it's technically incorrect and easy to fix.

**Minor note**: The `MIGRATE_PFN_COMPOUND` branch hardcodes `HPAGE_PMD_ORDER`:

```c
+		} else if (migrate_pfn[i] & MIGRATE_PFN_COMPOUND) {
+			order = HPAGE_PMD_ORDER;
```

This assumes compound pages are always PMD-sized (2MB on x86). This is currently true for the THP migration path, but if other compound orders are ever supported, this would need updating. A comment noting this assumption would be helpful.

**Verdict: Return type should be `unsigned long`. Otherwise correct.**

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13  4:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 15:16 [PATCH v8 0/4] Enable THP support in drm_pagemap Francois Dugast
2026-03-12 15:16 ` [PATCH v8 1/4] drm/pagemap: Unlock and put folios when possible Francois Dugast
2026-03-13  4:02   ` Claude review: " Claude Code Review Bot
2026-03-12 15:16 ` [PATCH v8 2/4] drm/pagemap: Add helper to access zone_device_data Francois Dugast
2026-03-13  4:02   ` Claude review: " Claude Code Review Bot
2026-03-12 15:16 ` [PATCH v8 3/4] drm/pagemap: Correct cpages calculation for migrate_vma_setup Francois Dugast
2026-03-13  4:02   ` Claude Code Review Bot [this message]
2026-03-12 15:16 ` [PATCH v8 4/4] drm/pagemap: Enable THP support for GPU memory migration Francois Dugast
2026-03-13  4:02   ` Claude review: " Claude Code Review Bot
2026-03-13  4:02 ` Claude review: Enable THP support in drm_pagemap Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-12 19:20 [PATCH v9 0/4] " Francois Dugast
2026-03-12 19:20 ` [PATCH v9 3/4] drm/pagemap: Correct cpages calculation for migrate_vma_setup Francois Dugast
2026-03-13  3:55   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260312151726.1779566-4-francois.dugast@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox