public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/komeda: Add support for Arm China Linlon-D6
Date: Sat, 14 Mar 2026 07:31:00 +1000	[thread overview]
Message-ID: <review-patch3-20260313033119.33686-4-cunyuan.liu@cixtech.com> (raw)
In-Reply-To: <20260313033119.33686-4-cunyuan.liu@cixtech.com>

Patch Review

Three minimal changes:

1. **Product ID define** (`malidp_product.h:23`): `LINLONDP_D6_PRODUCT_ID` set to `0x0060`, matching what the hardware reportedly reads from the PRODUCT_ID register. The naming convention (`LINLONDP_` vs `MALIDP_`) is reasonable to distinguish the Arm China product from the Arm products.

2. **d71_identify switch case** (`d71_dev.c:631`): Adding `LINLONDP_D6_PRODUCT_ID` alongside the existing D71 and D32 cases so the probing function accepts the Linlon-D6 product ID and returns the same `d71_chip_funcs`.

3. **of_device_id table** (`komeda_drv.c:107`): Adding the `"armchina,linlon-d6"` compatible string pointing to `d71_identify`, consistent with how `arm,mali-d32` is handled.

One minor observation: the `komeda_of_match` table entry for `"armchina,linlon-d6"` will match directly without needing the `"arm,mali-d71"` fallback compatible from the DT, since both are listed. This is fine — it means the driver works whether or not the fallback is present, and the binding schema ensures the fallback is always specified in DT anyway.

No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13 21:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  3:31 [PATCH v2 0/3] Arm China Linlon-D6 display controller support Cunyuan Liu
2026-03-13  3:31 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Arm Technology (China) Co., Ltd Cunyuan Liu
2026-03-13 21:30   ` Claude review: " Claude Code Review Bot
2026-03-13  3:31 ` [PATCH v2 2/3] dt-bindings: display: arm, komeda: add Arm China Linlon D6 compatible Cunyuan Liu
2026-03-13 21:31   ` Claude review: " Claude Code Review Bot
2026-03-13  3:31 ` [PATCH v2 3/3] drm/komeda: Add support for Arm China Linlon-D6 Cunyuan Liu
2026-03-13 21:31   ` Claude Code Review Bot [this message]
2026-03-13 21:30 ` Claude review: Arm China Linlon-D6 display controller support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-11  5:55 [PATCH 0/3] " Cunyuan Liu
2026-03-11  5:55 ` [PATCH 3/3] drm/komeda: Add support for Arm China Linlon-D6 Cunyuan Liu
2026-03-11 21:17   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260313033119.33686-4-cunyuan.liu@cixtech.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox