From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/komeda: Add support for Arm China Linlon-D6 Date: Sat, 14 Mar 2026 07:31:00 +1000 Message-ID: In-Reply-To: <20260313033119.33686-4-cunyuan.liu@cixtech.com> References: <20260313033119.33686-1-cunyuan.liu@cixtech.com> <20260313033119.33686-4-cunyuan.liu@cixtech.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Three minimal changes: 1. **Product ID define** (`malidp_product.h:23`): `LINLONDP_D6_PRODUCT_ID` = set to `0x0060`, matching what the hardware reportedly reads from the PRODU= CT_ID register. The naming convention (`LINLONDP_` vs `MALIDP_`) is reasona= ble to distinguish the Arm China product from the Arm products. 2. **d71_identify switch case** (`d71_dev.c:631`): Adding `LINLONDP_D6_PROD= UCT_ID` alongside the existing D71 and D32 cases so the probing function ac= cepts the Linlon-D6 product ID and returns the same `d71_chip_funcs`. 3. **of_device_id table** (`komeda_drv.c:107`): Adding the `"armchina,linlo= n-d6"` compatible string pointing to `d71_identify`, consistent with how `a= rm,mali-d32` is handled. One minor observation: the `komeda_of_match` table entry for `"armchina,lin= lon-d6"` will match directly without needing the `"arm,mali-d71"` fallback = compatible from the DT, since both are listed. This is fine =E2=80=94 it me= ans the driver works whether or not the fallback is present, and the bindin= g schema ensures the fallback is always specified in DT anyway. No issues. --- Generated by Claude Code Patch Reviewer