From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur
Date: Sat, 14 Mar 2026 07:07:32 +1000
Message-ID: <review-patch3-20260313120814.1312410-4-sibi.sankar@oss.qualcomm.com>
In-Reply-To: <20260313120814.1312410-4-sibi.sankar@oss.qualcomm.com>
References: <20260313120814.1312410-1-sibi.sankar@oss.qualcomm.com> <20260313120814.1312410-4-sibi.sankar@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Converts the fastrpc compatible from a simple `enum` to `oneOf` to support =
`qcom,glymur-fastrpc` with `qcom,kaanapali-fastrpc` fallback:

```yaml
    oneOf:
      - enum:
          - qcom,kaanapali-fastrpc
          - qcom,fastrpc
      - items:
          - enum:
              - qcom,glymur-fastrpc
          - const: qcom,kaanapali-fastrpc
```

The restructuring is correct. The existing single-string compatibles are pr=
eserved in the `enum` branch, and the new two-string compatible is added as=
 an `items` branch. Has Reviewed-by from Krzysztof Kozlowski.

**Minor observation**: The `enum` wrapping `qcom,glymur-fastrpc` is technic=
ally unnecessary when there's only one entry =E2=80=94 a bare `const: qcom,=
glymur-fastrpc` would suffice. However, using `enum` is a common DT-binding=
 convention that allows for easy future additions, so this is acceptable st=
yle.

---
Generated by Claude Code Patch Reviewer