public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel
Date: Mon, 16 Mar 2026 11:54:47 +1000	[thread overview]
Message-ID: <review-patch3-20260314-panel-patches-v4-3-1ecbb2c0c3c8@gmail.com> (raw)
In-Reply-To: <20260314-panel-patches-v4-3-1ecbb2c0c3c8@gmail.com>

Patch Review

**1. Regulator voltage mismatch for `panel_vci_3p0`.** This is the most significant issue. The regulator node is named `panel_vci_3p0` suggesting 3.0V, but the actual voltage specified is 1.8V (mbox lines 493-504):
```
panel_vci_3p0: regulator-panel-vci {
    ...
    regulator-name = "panel_vci_3p0";
    regulator-min-microvolt = <1800000>;
    regulator-max-microvolt = <1800000>;
```
Either the name is wrong (should reflect 1.8V), or the voltage is wrong (should be 3000000). VCI for OLED panels is typically 3.0V, so the name might be correct and the voltage should be `<3000000>`. Please verify against the hardware schematic. If 1.8V is actually correct, change the name to avoid confusion.

**2. Extra blank line.** There's a double blank line between `&mdss_dsi0_out` and `&mdss_dsi0_phy` blocks (mbox lines 547-548):
```

&mdss_dsi0_phy {
```
Should be a single blank line for consistency with the rest of the file.

**3. `regulator-boot-on` on `panel_vci_3p0`.** The `panel_vdd_1p8` regulator has `vin-supply = <&vreg_l9a>` but `panel_vci_3p0` does not specify a `vin-supply`. If this GPIO-controlled regulator is powered by a PMIC rail, the `vin-supply` should be specified for proper power sequencing. The commit message mentions "ldo and iovcc gpio pins" but doesn't fully explain the VCI supply chain.

**4. `regulator-boot-on` without `regulator-always-on`.** Both fixed regulators use `regulator-boot-on` which prevents them from being disabled at boot. This is common for panel regulators to avoid flicker, but worth noting that the driver does call `regulator_bulk_disable()` in unprepare, so these regulators will be disabled during runtime PM. This is fine.

The DTS changes have appropriate Reviewed-by tags from Dmitry and Konrad, which is good.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-16  1:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 21:46 [PATCH v4 0/3] Add support for the Samsung S6E8FCO DSI and M1906F9 display panel Yedaya Katsman
2026-03-14 21:46 ` [PATCH v4 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO-M1906F9 Yedaya Katsman
2026-03-15  8:43   ` Krzysztof Kozlowski
2026-03-16  1:54     ` Claude review: " Claude Code Review Bot
2026-03-14 21:46 ` [PATCH v4 2/3] drm: panel: Add Samsung S6E8FCO DSI controller for M1906F9 panel Yedaya Katsman
2026-03-16  1:54   ` Claude review: " Claude Code Review Bot
2026-03-14 21:46 ` [PATCH v4 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel Yedaya Katsman
2026-03-16  1:54   ` Claude Code Review Bot [this message]
2026-03-16  1:54 ` Claude review: Add support for the Samsung S6E8FCO DSI and M1906F9 display panel Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-20 14:41 [PATCH v7 0/3] Add support for the Samsung S6E8FC0 " Yedaya Katsman
2026-03-20 14:41 ` [PATCH v7 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel Yedaya Katsman
2026-03-21 17:41   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260314-panel-patches-v4-3-1ecbb2c0c3c8@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox