From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel Date: Mon, 16 Mar 2026 11:54:47 +1000 Message-ID: In-Reply-To: <20260314-panel-patches-v4-3-1ecbb2c0c3c8@gmail.com> References: <20260314-panel-patches-v4-0-1ecbb2c0c3c8@gmail.com> <20260314-panel-patches-v4-3-1ecbb2c0c3c8@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **1. Regulator voltage mismatch for `panel_vci_3p0`.** This is the most significant issue. The regulator node is named `panel_vci_3p0` suggesting 3.0V, but the actual voltage specified is 1.8V (mbox lines 493-504): ``` panel_vci_3p0: regulator-panel-vci { ... regulator-name = "panel_vci_3p0"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; ``` Either the name is wrong (should reflect 1.8V), or the voltage is wrong (should be 3000000). VCI for OLED panels is typically 3.0V, so the name might be correct and the voltage should be `<3000000>`. Please verify against the hardware schematic. If 1.8V is actually correct, change the name to avoid confusion. **2. Extra blank line.** There's a double blank line between `&mdss_dsi0_out` and `&mdss_dsi0_phy` blocks (mbox lines 547-548): ``` &mdss_dsi0_phy { ``` Should be a single blank line for consistency with the rest of the file. **3. `regulator-boot-on` on `panel_vci_3p0`.** The `panel_vdd_1p8` regulator has `vin-supply = <&vreg_l9a>` but `panel_vci_3p0` does not specify a `vin-supply`. If this GPIO-controlled regulator is powered by a PMIC rail, the `vin-supply` should be specified for proper power sequencing. The commit message mentions "ldo and iovcc gpio pins" but doesn't fully explain the VCI supply chain. **4. `regulator-boot-on` without `regulator-always-on`.** Both fixed regulators use `regulator-boot-on` which prevents them from being disabled at boot. This is common for panel regulators to avoid flicker, but worth noting that the driver does call `regulator_bulk_disable()` in unprepare, so these regulators will be disabled during runtime PM. This is fine. The DTS changes have appropriate Reviewed-by tags from Dmitry and Konrad, which is good. --- Generated by Claude Code Patch Reviewer