From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd: treat max_tmds_clock==0 as unconstrained
Date: Mon, 16 Mar 2026 11:48:52 +1000 [thread overview]
Message-ID: <review-patch3-20260315223307.45807-4-johanneswueller@gmail.com> (raw)
In-Reply-To: <20260315223307.45807-4-johanneswueller@gmail.com>
Patch Review
**This is the most straightforward and correct patch in the series.** When an EDID lacks an HDMI VSDB, `max_tmds_clock` will be 0. Treating 0 as "unlimited" rather than "no clock allowed" is the right fix, and matches how other drivers handle this (e.g. the DRM core's `drm_hdmi_compute_mode_clock()` treats 0 as unconstrained).
```c
if (info->max_tmds_clock == 0 ||
normalized_clk <= info->max_tmds_clock) {
```
This is clean and correct. However, should this also be gated on `edid_overridden`? Without the override flag check, this changes behavior for any display that genuinely reports `max_tmds_clock == 0` through its real EDID, which could potentially allow modes that exceed the display's capabilities. That said, the HDMI spec says a conformant EDID should always include a VSDB with a valid max_tmds_clock if it supports HDMI, so 0 generally means "not specified" rather than "zero limit" — making this change safe regardless of override status.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-16 1:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 22:33 [PATCH 0/4] drm/amd: fix HDMI output with non-HDMI EDID overrides Johannes Wüller
2026-03-15 22:33 ` [PATCH 1/4] drm: add edid_overridden flag to drm_connector Johannes Wüller
2026-03-16 1:48 ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 2/4] drm/amd: fix HDMI signal type for EDID overrides Johannes Wüller
2026-03-16 1:48 ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 3/4] drm/amd: treat max_tmds_clock==0 as unconstrained Johannes Wüller
2026-03-16 1:48 ` Claude Code Review Bot [this message]
2026-03-15 22:33 ` [PATCH 4/4] drm/amd: fix force_yuv420/422_output being ignored Johannes Wüller
2026-03-16 1:48 ` Claude review: " Claude Code Review Bot
2026-03-16 1:48 ` Claude review: drm/amd: fix HDMI output with non-HDMI EDID overrides Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260315223307.45807-4-johanneswueller@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox