public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU
Date: Sun, 22 Mar 2026 05:00:32 +1000	[thread overview]
Message-ID: <review-patch3-20260318-rimob-new-features-v2-3-c1bf8917449e@protonmail.com> (raw)
In-Reply-To: <20260318-rimob-new-features-v2-3-c1bf8917449e@protonmail.com>

Patch Review

This DTS patch enables the MDSS display subsystem, DSI panel, WLED backlight, and GPU.

**Observation: `output-high` in pinctrl for active-low reset GPIO**

The panel pinctrl sets:
```dts
panel_default: panel-default-state {
    pins = "gpio61";
    ...
    output-high;
};
```

And the panel node has:
```dts
reset-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
```

With `GPIO_ACTIVE_LOW`, `gpiod_set_value(1)` drives the pin low (asserting reset). The driver's `nt35532_reset()` starts with `gpiod_set_value_cansleep(ctx->reset_gpio, 0)` which drives the pin high (de-asserting reset). The pinctrl `output-high` is consistent — the panel starts with reset de-asserted. This looks correct.

The probe requests the GPIO with `GPIOD_OUT_HIGH` (logical high = pin driven low = reset asserted), then `nt35532_reset()` deasserts and pulses. This sequencing is fine.

No issues found with the GPU or WLED configuration.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-21 19:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 22:28 [PATCH v2 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-18 22:28 ` [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-19  9:09   ` Krzysztof Kozlowski
2026-03-20 22:32     ` cristian_ci
2026-03-21  9:56       ` Krzysztof Kozlowski
2026-03-21 16:15         ` cristian_ci
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-19  2:27   ` Dmitry Baryshkov
2026-03-20  7:19     ` cristian_ci
2026-03-20  7:39       ` Dmitry Baryshkov
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-19  2:54   ` Dmitry Baryshkov
2026-03-21 19:00   ` Claude Code Review Bot [this message]
2026-03-18 22:28 ` [PATCH v2 4/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable WiFi/Bluetooth Cristian Cozzolino via B4 Relay
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen Cristian Cozzolino via B4 Relay
2026-03-19 10:42   ` Konrad Dybcio
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-19 10:43   ` Konrad Dybcio
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-21 19:00 ` Claude review: Enable new features for flipkart-rimob Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-21 16:23 [PATCH v3 0/6] " Cristian Cozzolino via B4 Relay
2026-03-21 16:23 ` [PATCH v3 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 [PATCH 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-08 15:52 ` [PATCH 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260318-rimob-new-features-v2-3-c1bf8917449e@protonmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox