From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU
Date: Sun, 22 Mar 2026 05:00:32 +1000
Message-ID: <review-patch3-20260318-rimob-new-features-v2-3-c1bf8917449e@protonmail.com>
In-Reply-To: <20260318-rimob-new-features-v2-3-c1bf8917449e@protonmail.com>
References: <20260318-rimob-new-features-v2-0-c1bf8917449e@protonmail.com> <20260318-rimob-new-features-v2-3-c1bf8917449e@protonmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

This DTS patch enables the MDSS display subsystem, DSI panel, WLED backligh=
t, and GPU.

**Observation: `output-high` in pinctrl for active-low reset GPIO**

The panel pinctrl sets:
```dts
panel_default: panel-default-state {
    pins =3D "gpio61";
    ...
    output-high;
};
```

And the panel node has:
```dts
reset-gpios =3D <&tlmm 61 GPIO_ACTIVE_LOW>;
```

With `GPIO_ACTIVE_LOW`, `gpiod_set_value(1)` drives the pin low (asserting =
reset). The driver's `nt35532_reset()` starts with `gpiod_set_value_canslee=
p(ctx->reset_gpio, 0)` which drives the pin high (de-asserting reset). The =
pinctrl `output-high` is consistent =E2=80=94 the panel starts with reset d=
e-asserted. This looks correct.

The probe requests the GPIO with `GPIOD_OUT_HIGH` (logical high =3D pin dri=
ven low =3D reset asserted), then `nt35532_reset()` deasserts and pulses. T=
his sequencing is fine.

No issues found with the GPU or WLED configuration.

---
Generated by Claude Code Patch Reviewer