From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: phy: qcom-uniphy: add more registers from display PHYs Date: Sun, 22 Mar 2026 04:56:09 +1000 Message-ID: In-Reply-To: <20260319-fd-hdmi-phy-v6-3-cefc08a55470@oss.qualcomm.com> References: <20260319-fd-hdmi-phy-v6-0-cefc08a55470@oss.qualcomm.com> <20260319-fd-hdmi-phy-v6-3-cefc08a55470@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds ~42 additional register definitions and bitfield macros to `phy-qcom-uniphy.h` for use by the HDMI PHY PLL code in patch 4. **Well-structured field definitions** The use of `GENMASK` and named field macros is good practice: ```c #define UNIPHY_PLL_GLB_CFG 0x0020 #define UNIPHY_PLL_GLB_CFG_PLL_PWRDN_B BIT(0) #define UNIPHY_PLL_GLB_CFG_PLL_LDO_PWRDN_B BIT(1) #define UNIPHY_PLL_GLB_CFG_PLL_PWRGEN_PWRDN_B BIT(2) #define UNIPHY_PLL_GLB_CFG_PLL_ENABLE BIT(3) ``` This enables the `FIELD_PREP`/`FIELD_GET` usage in patch 4, replacing magic numbers. No issues found. Clean additive patch. --- --- Generated by Claude Code Patch Reviewer