From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Match devices exposing the protocol on the SAHARA channel Date: Sun, 22 Mar 2026 04:44:33 +1000 Message-ID: In-Reply-To: <20260319-sahara_protocol_new_v2-v4-3-47ad79308762@oss.qualcomm.com> References: <20260319-sahara_protocol_new_v2-v4-0-47ad79308762@oss.qualcomm.com> <20260319-sahara_protocol_new_v2-v4-3-47ad79308762@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `"SAHARA"` to the MHI device ID match table. **Issues:** - **Style inconsistency** in the match table entry: ```c { .chan = "QAIC_SAHARA", }, { .chan = "SAHARA"}, // missing trailing comma and space before } ``` Should be `{ .chan = "SAHARA", },`. - **`MODULE_DEVICE_TABLE` should have been in patch 2** where the driver became a standalone module, to avoid a bisection point where the module exists but cannot be auto-loaded. --- Generated by Claude Code Patch Reviewer