public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rzg2l_mipi_dsi: Fix deassert of CMN_RSTB signal
Date: Sun, 22 Mar 2026 04:12:40 +1000	[thread overview]
Message-ID: <review-patch3-20260319164833.409126-4-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260319164833.409126-4-biju.das.jz@bp.renesas.com>

Patch Review

Moves `reset_control_deassert()` from `rzg2l_mipi_dsi_dphy_init()` to `rzg2l_mipi_dsi_startup()`, placing it after Link register writes. This ensures PHY timing registers and Link registers are written before deasserting CMN_RSTB, per Section 34.4.2.1.

```c
+	if (dsi->rstc) {
+		ret = reset_control_deassert(dsi->rstc);
+		if (ret < 0)
+			goto err_phy;
+
+		udelay(1);
+	}
```

**The NULL check is unnecessary but harmless.** `reset_control_deassert(NULL)` returns 0, so the `if (dsi->rstc)` guard is not needed for correctness. However, it does skip the `udelay(1)` on RZ/V2H where there's no reset to deassert, which is a minor optimization. This is fine.

**Note:** The `udelay(1)` kept here is the old value; patch 4 will change it to `fsleep(1000)`. This is fine for bisectability — the ordering fix is separated from the timing fix.

**No Fixes tag or stable Cc:** Unlike patches 1 and 2, this patch lacks `Fixes:` and `Cc: stable` tags, even though it arguably has a stronger case for them than patch 2 — it's fixing the order of operations per the hardware manual. This seems inconsistent with the rest of the series.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-21 18:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 16:48 [PATCH v2 0/4] Improvements on RZ/G2L MIPI DSI driver Biju
2026-03-19 16:48 ` [PATCH v2 1/4] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Biju
2026-03-21 18:12   ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 2/4] drm: renesas: rzg2l_mipi_dsi: Fix assert of CMN_RSTB signal Biju
2026-03-21 18:12   ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 3/4] drm: renesas: rzg2l_mipi_dsi: Fix deassert " Biju
2026-03-21 18:12   ` Claude Code Review Bot [this message]
2026-03-19 16:48 ` [PATCH v2 4/4] drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay to 1 msec Biju
2026-03-21 18:12   ` Claude review: " Claude Code Review Bot
2026-03-21 18:12 ` Claude review: Improvements on RZ/G2L MIPI DSI driver Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260319164833.409126-4-biju.das.jz@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox